Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the correct compile flag for the memory sanitizer build #1680

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Set the correct compile flag for the memory sanitizer build #1680

merged 1 commit into from
Jan 30, 2024

Conversation

SWilson4
Copy link
Member

Fixes a typo in our USE_SANITIZER configuration.

Partially addresses #1366.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

No to both.

@SWilson4 SWilson4 requested a review from dstebila as a code owner January 26, 2024 20:59
@SWilson4 SWilson4 mentioned this pull request Jan 26, 2024
Open
baentsch
baentsch approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this bummer @SWilson4 !

@SWilson4 SWilson4 merged commit f606d3d into main Jan 30, 2024
56 checks passed
@SWilson4 SWilson4 deleted the sw-memory-sanitizer-flag branch January 30, 2024 21:00
@BrewTestBot BrewTestBot mentioned this pull request Mar 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baentsch baentsch baentsch approved these changes

@dstebila dstebila dstebila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SWilson4 @dstebila @baentsch